Skip to content

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Jul 23, 2019

  • Use dylib instead of so on Mac OSX
  • Remove unnessecary MSVC project file
  • Suppress MSVC assert popups

With this LibSass build needs some fixups.

See https://stackoverflow.com/questions/35568122/why-isnt-dyld-library-path-being-propagated-here

@@ -1,361 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an accidental removal? This file was added to categorize files in Solution Explorer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I removed it since it puts quite a burden on devs to keep it in sync.
And it didn't seem to be relevant for successful builds, so I removed it.
Is it possible to have only one master list of files for MSVC and still support this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter is just a logical view, a design-time artifact to list files in custom structure in the Visual Studio - https://stackoverflow.com/questions/6941868/why-do-vcxproj-filters-files-exist

Master:

image

Branch - without these filters, the solution explorer looks like this:

image

this is an annoyance of vcxproj project system, that they try to keep the view separate from build. In other project systems of VS, they simply use filesystem hierarchy (with wildcard) as the default and add ability to link out-of-the-tree files that projects on top of filesystem view. Insult to the injury, vcxproj.filters do not support wildcards.

If we toggle to the filesystem view of project provided by VS, then we do not see LibSass files with out default structure (we recommend in docs to clone sassc at libsass root):

image

If the maintenance is becoming a nightmare (i.e. we are adding/moving files in libsass too often), lets remove this file. Otherwise we can keep it up to date with a little automation (I can add a task which will update the filter file and we can run it like msbuild /t:UpdateFilters win/sassc.vcxproj).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that thorough explanation @am11!
Need to think about how to proceed with this later, for the moment the files can stay in.
I will update the PRs for libsass/sassc in a few hours when I'm home. The most irritating thing
for me was actually that we had libsass source files referenced in sassc. Maybe there is at least
a way to get this also partially read from the actual libsass source directly (as with target file)?

@mgreter
Copy link
Contributor Author

mgreter commented Jul 23, 2019

Merging this to get things moving. Ci is 💚.

@mgreter mgreter merged commit 507f01b into sass:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants