Fix colours as map keys #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the eval visitor to correctly coerce the string node to a color node.
55efc28 to
dbb7d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the treatment of colours when used as map keys.
The current problem is named colours like purple are treated as identifiers meaning they're not evaluated and coerced into colours. This causes issues when doing operations that expect a colour like
map-get($map, purple). In this case the argumentpurpleis treated as a colours but the map keypurpleis a string which causes the lookup to (correctly) fail.Fixes #652. Specs added sass/sass-spec#156.