Radically simply the map parser logic #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
898a44f to
d66a5f5
Compare
d66a5f5 to
e3d8429
Compare
xzyfer
added a commit
that referenced
this pull request
Oct 30, 2014
Radically simply the map parser logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR radically simplifies the maps parser logic. I've removed the prelexer hack I added to get 3.0 out the door with useful maps. The prelexer hack imposed limitations on what could be in a map key subsequently making #555, #574 impossible. It also changed the parser token resolution flow which meant #575 wasn't possible.
Fixes #575. Specs added sass/sass-spec@eaad1c6, sass/sass-spec#110.