Skip to content

fix: str-slice can't start at 0 #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2019
Merged

fix: str-slice can't start at 0 #2951

merged 1 commit into from
Jul 26, 2019

Conversation

nschonni
Copy link
Collaborator

@nschonni nschonni mentioned this pull request Jul 18, 2019
Closed
@nschonni nschonni requested a review from mgreter July 19, 2019 00:28
mgreter
mgreter approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@mgreter mgreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nschonni nschonni merged commit 2263d9b into sass:master Jul 26, 2019
@nschonni nschonni deleted the fix--str-slice-can't-start-at-0 branch July 26, 2019 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgreter mgreter mgreter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

str-slice() should allow very negative $start-at values
2 participants
@nschonni @mgreter