Skip to content

fix: throw on weitht passed to CSS3 invert() #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2019
Merged

fix: throw on weitht passed to CSS3 invert() #2950

merged 1 commit into from
Jul 26, 2019

Conversation

nschonni
Copy link
Collaborator

@nschonni
Copy link
Collaborator Author

@mgreter there is an edge case that I wasn't sure how to handle. If they manually pass in 100% as the weight it will still pass.
I'm not sure if there is a function that I didn't see for checking whether a parameter is set vs. using the default in the signiture.

@nschonni nschonni force-pushed the fix--throw-on-weitht-passed-to-CSS3-invert branch from 17e7474 to d972c50 Compare July 18, 2019 05:39
@nschonni nschonni requested a review from mgreter July 19, 2019 00:28
mgreter
mgreter approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@mgreter mgreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nschonni nschonni merged commit 6ea4cb2 into sass:master Jul 26, 2019
@nschonni nschonni deleted the fix--throw-on-weitht-passed-to-CSS3-invert branch July 26, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgreter mgreter mgreter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invert() shouldn't allow both a number and a weight
2 participants
@nschonni @mgreter