Add PSR-20 clock implementation declaration #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declares that DuoClock provides psr/clock-implementation to help package managers identify this as a PSR-20 compatible clock.
There was a problem hiding this comment.
Pull Request Overview
This PR declares PSR-20 clock implementation compatibility by adding a "provide" section to composer.json, indicating that the DuoClock package provides a PSR-20 compatible clock implementation.
- Adds composer.json "provide" declaration for psr/clock-implementation
Comments suppressed due to low confidence (1)
composer.json:28
- The PSR-20 specification uses semantic versioning starting with version 1.0.0, not 1.0. The provide declaration should specify "1.0.0" to match the actual PSR-20 specification version.
"psr/clock-implementation": "1.0"
Pull Request Test Coverage Report for Build 16558072450Details
💛 - Coveralls |
2 similar comments
Pull Request Test Coverage Report for Build 16558072450Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 16558072450Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declares that DuoClock provides psr/clock-implementation to help package managers identify this as a PSR-20 compatible clock.