Skip to content

Fix DATABASE_URL support #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix DATABASE_URL support #575

merged 2 commits into from
Feb 25, 2025

Conversation

znz
Copy link
Contributor

@znz znz commented Feb 10, 2025 •
edited
Loading

Because this script updates config/database.yml, it also need to set DB_PASS and DB_NAME.

Without this, config/database.yml includes password: '' and database: redmine_production (that does not match DATABASE_URL), and I see following errors.

[4fe1db4e-b38a-4e67-bfb2-049dbfea712d] ActiveRecord::ConnectionNotEstablished (connection to server at "172.17.0.2", port 5432 failed: fe_sendauth: no password supplied
):
[4fe1db4e-b38a-4e67-bfb2-049dbfea712d] 
Causes:
[4fe1db4e-b38a-4e67-bfb2-049dbfea712d] PG::ConnectionBad (connection to server at "172.17.0.2", port 5432 failed: fe_sendauth: no password supplied
)

@znz
Fix DATABASE_URL support
106a0cd 
Because this script updates `config/database.yml`,
it also need to set `DB_PASS` and `DB_NAME`.
@jcormier
Copy link
Collaborator

Thanks. Could you provide an example DATABASE_URL in a comment for postgres and mysql2 so it's clear how to test the code?

@jcormier
Copy link
Collaborator

Thanks

@jcormier jcormier merged commit c04e3c1 into sameersbn:master Feb 25, 2025
1 check passed
@jcormier
Copy link
Collaborator

Do you want a version number release or are you fine with using latest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znz @jcormier