Fix #1661: no argument required in random boolean. #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes issue #1661 by adding support for generating random boolean values without requiring arguments. The fix ensures that the typia.createRandom<boolean>() function generates a proper random boolean generator that calls the internal randomBoolean() method without parameters.
- Added boolean case handling in
RandomProgrammer.tsto generate random booleans usingrandomBoolean()with no arguments - Created a test to verify the random boolean generator produces the expected function signature
- Bumped package version from 9.7.1 to 9.7.2
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/programmers/RandomProgrammer.ts | Added boolean type handling to generate randomBoolean() calls without arguments |
| test/src/features/issues/test_issue_1661_random_boolean.ts | Added test to validate random boolean generation produces correct function signature |
| package.json | Version bump from 9.7.1 to 9.7.2 |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with random boolean generation by adding support for generating random boolean values and includes a corresponding test. It also bumps the package version to reflect these changes.
Random boolean support:
RandomProgrammer.tsto handle the"boolean"atomic type, ensuring that random boolean values are generated using the newrandomBooleaninternal method.Testing:
test_issue_1661_random_boolean.tsto validate that the random boolean generator is correctly invoked.Version update:
9.7.1to9.7.2inpackage.jsonto reflect the new feature and bug fix.