Skip to content

Conversation

samchon
Copy link
Owner

@samchon samchon commented Jul 6, 2025

This pull request introduces several updates to the typia project, including dependency version upgrades, type safety improvements, and formatting adjustments in schema descriptions. The most important changes are grouped below by theme.

Dependency Updates:

  • Updated the @samchon/openapi dependency from version 4.3.1 to 4.4.0 in package.json, pnpm-lock.yaml, and peer dependencies. This ensures compatibility with the latest features and fixes. [1] [2] [3] [4] [5]

Type Safety Improvements:

  • Changed the type of the value property in TypeGuardError and its namespace from any to unknown for stricter type safety. [1] [2]

Schema Description Formatting:

  • Adjusted formatting in various JSON schema descriptions for better readability, including breaking long lines into shorter ones and improving indentation. This affects files test/schemas/json.schema/v3_0/UltimateUnion.json and test/schemas/json.schema/v3_1/UltimateUnion.json. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

These changes collectively enhance the project's maintainability, type safety, and documentation clarity.

@samchon samchon requested a review from Copilot July 6, 2025 21:44
@samchon samchon self-assigned this Jul 6, 2025
@samchon samchon added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 6, 2025
Copy link

socket-security bot commented Jul 6, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​samchon/​openapi@​4.3.1 ⏵ 4.4.010010010096 +2100

View full report

Copy link

pkg-pr-new bot commented Jul 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/typia@1603

commit: 84e6a6a

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the LLM application test schemas to use $ref-based definitions, enabling shared type references and cleaner JSON schema structures.

  • Enabled "reference": true in each schema’s options block.
  • Replaced inline type definitions under each functions entry with $ref to a single $defs definition.
  • Introduced $defs sections that centralize definition of object types previously duplicated.

Reviewed Changes

Copilot reviewed 143 out of 1086 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/schemas/llm.application/3.1/ObjectGenericArray.json Enabled references and introduced $ref/$defs for object types.
test/schemas/llm.application/3.1/ObjectGenericAlias.json Centralized alias schema under $defs and replaced inline definitions.
test/schemas/llm.application/3.1/ObjectDynamic.json Converted inline dynamic type definitions to $ref+$defs.
test/schemas/llm.application/3.1/ObjectDescription.json Refactored object descriptions into $defs and cleaned up inline comments.
test/schemas/llm.application/3.1/ObjectDate.json Consolidated date-related fields under $defs references.
test/schemas/llm.application/3.1/ObjectAlias.json Moved member schema into $defs and updated all $ref usages.
test/schemas/llm.application/3.1/DynamicUnion.json Migrated union definitions to shared $defs.
... (plus all other test/schemas/llm.application/3.1/*.json files, following the same pattern) ...
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

test/schemas/llm.application/3.1/ObjectGenericArray.json:22

  • [nitpick] The $defs block for ObjectGenericArray is repeated under multiple function entries (first, reduce, output, etc.). Consider moving the shared definitions to the root of the schema (outside individual functions) to avoid duplication and simplify maintenance.
        "$defs": {

@samchon samchon merged commit 45b1ee7 into master Jul 6, 2025
10 checks passed
@samchon samchon deleted the feat/openapi branch July 6, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant