Support validateEquals() function for LLM.
#1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for a new validateEquals() function for LLM applications by adding configuration options for stricter validation. The changes enable users to configure whether validation should allow superfluous properties or enforce exact equality checks.
- Added
equalconfiguration option to LLM controller and application functions to enable strict validation - Updated internal validation logic to use the new
strictconfiguration throughout the pipeline - Enhanced type definitions to support the new configuration parameters across multiple components
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump to 9.6.0-dev.20250719 for the new feature |
| src/llm.ts | Added equal configuration option to controller and application function type definitions |
| src/programmers/llm/LlmApplicationProgrammer.ts | Updated function signatures to support strict config and fixed validator function naming |
| src/programmers/llm/LlmModelPredicator.ts | Enhanced return type to include strict configuration option |
| src/transformers/features/llm/LlmApplicationTransformer.ts | Updated config type to include strict option for type consistency |
Comments suppressed due to low confidence (1)
src/llm.ts:158
- [nitpick] The configuration option is named 'equal' in the controller function but 'strict' is used internally. Consider using consistent naming throughout the codebase - either 'equal' or 'strict' everywhere.
equal: boolean;
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to configuration handling and validation logic across multiple files, along with a version update in
package.json. The changes primarily focus on adding new configuration options (strictandequal) to improve validation flexibility and strictness.Version Update:
package.json: Updated the package version from9.5.0to9.6.0-dev.20250719.Configuration Enhancements:
src/llm.ts: Addedequalas a new configuration option tocontrollerandapplicationfunctions, enabling stricter validation. [1] [2]src/programmers/llm/LlmApplicationProgrammer.ts: Introducedstrictconfiguration option in multiple functions and updated validation logic to use this option. [1] [2] [3] [4] [5]src/programmers/llm/LlmModelPredicator.ts: Added support for thestrictconfiguration option in thegetConfigmethod.src/transformers/features/llm/LlmApplicationTransformer.ts: Updated theconfigobject to include thestrictoption when retrieving configuration viaLlmModelPredicator.