Remake typia playground compiler #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the playground compiler to use embed-typescript, streamlines the build process, and enhances the UI components in the playground.
- Replaced the old TypeScriptCompiler service with a new
EmbedTypeScript-based implementation undersrc/compiler - Updated build scripts and
rspack.config.jsto include a dedicated compiler build step and new file paths - Improved playground components: added default script constant, JSON output support, and stricter typing
Reviewed Changes
Copilot reviewed 16 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/pages/Playground.tsx | Updated compiler service import, compile/transform logic, and script defaults |
| website/src/compiler/index.ts | New EmbedTypeScript-based compiler worker implementation |
| website/src/components/playground/OutputViewer.tsx | Extended to accept json language, introduced IProps namespace |
| website/src/components/playground/PLAYGROUND_DEFAULT_SCRIPT.ts | Added default playground script constant |
| website/rspack.config.js | Adjusted entry and output paths for new compiler directory |
| website/package.json | Added build:compiler script, moved TypeScript to devDeps |
Files not reviewed (1)
- website/compiler-dependencies/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
website/src/pages/Playground.tsx:270
- Move the
createCompilerServicedeclaration above its first usage in the component to avoid a reference error caused by the temporal dead zone ofconst.
const createCompilerService = new Singleton(async () => {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request significantly refactors the
websitedirectory to improve the compiler infrastructure, streamline the build process, and enhance the playground's functionality. The most notable changes include replacing the old compiler implementation with a new one based onembed-typescript, restructuring file paths, and updating the playground's UI components.Compiler Refactor and Infrastructure Updates:
TypeScriptCompilerimplementation with a new compiler service usingembed-typescriptfor enhanced modularity and maintainability. (website/src/compiler/ICompilerService.ts,website/src/compiler/index.ts,website/build/compiler.js, [1] [2] [3]package.jsonforcompiler-dependenciesto manage dependencies for the compiler service. (website/compiler-dependencies/package.json, website/compiler-dependencies/package.jsonR1-R18)Build Process Improvements:
build:compiler) and removed redundant raw data generation logic. (website/package.json, [1] [2] [3] [4]rspack.config.jsto reflect the new file structure and output paths for the compiler. (website/rspack.config.js, website/rspack.config.jsL2-R7)Playground Enhancements:
PLAYGROUND_DEFAULT_SCRIPTconstant to provide a default script for the playground. (website/src/components/playground/PLAYGROUND_DEFAULT_SCRIPT.ts, website/src/components/playground/PLAYGROUND_DEFAULT_SCRIPT.tsR1-R24)OutputViewercomponent to support a newjsonlanguage option and refactored its props for better type safety. (website/src/components/playground/OutputViewer.tsx, [1] [2]IMessagetype inConsoleViewerto useunknowninstead ofanyfor stricter type checking. (website/src/components/playground/ConsoleViewer.tsx, website/src/components/playground/ConsoleViewer.tsxL54-R54)File Structure and Dependency Updates:
compilersdirectory and related references tocompilerfor consistency. (website/.gitignore,website/rspack.config.js, [1] [2]embed-typescriptto the project. (website/package.json, [1] [2]These changes collectively enhance the maintainability, performance, and user experience of the
websiteproject.