New function typia.llm.controller<Class, Model>().
#1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new LLM controller function (typia.llm.controller), upgrades the @samchon/openapi dependency, and improves the transformer logic for both LLM applications and controllers.
- Added new test cases and inputs for controller functionality.
- Integrated and refactored LLM controller and application transformers.
- Updated source and factory functions supporting the new controller API.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/src/features/llm.controller/test_llm_controller.ts | New test validating the LLM controller API. |
| test/generate/input/generate_llm.ts | Added sample usage of the controller along with async executor functions. |
| test-esm/src/index.ts | Updated tests to include the new controller configuration. |
| test-esm/generate/output/index.ts | Modified output generation to use ILlmController and improved formatting. |
| test-esm/generate/input/index.ts | Transitioned from ILlmApplication to ILlmController usage. |
| src/transformers/features/llm/LlmControllerTransformer.ts | Introduced transformer for LLM controller with error checks. |
| src/transformers/features/llm/LlmApplicationTransformer.ts | Refactored decompose logic and transformation for LLM applications. |
| src/transformers/CallExpressionTransformer.ts | Integrated LLM controller transformer in the functors map. |
| src/llm.ts | Added controller overloads and documentation updates. |
| src/factories/ExpressionFactory.ts | Enhanced selfCall with an optional type parameter. |
| package.json | Version bump and dependency upgrade for @samchon/openapi. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
src/transformers/features/llm/LlmApplicationTransformer.ts:82
- [nitpick] The variable name 'top' is ambiguous; consider renaming it to something like 'genericType' for improved clarity.
const top: ts.Node = props.expression.typeArguments[0]!;
src/transformers/features/llm/LlmControllerTransformer.ts:20
- [nitpick] The error message for the case when only one argument is provided ('no executor.') might benefit from additional context about the expected arguments to assist debugging.
else if (props.expression.arguments.length === 1)
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates and enhancements, primarily focusing on dependency upgrades, new functionality for LLM (Large Language Model) controllers, and improvements to the transformer logic. Below is a summary of the most significant changes grouped by theme.
Dependency Updates
@samchon/openapidependency to version4.3.0-dev.20250511inpackage.jsonandpnpm-lock.yaml. This includes updates to the dependency specification, resolution integrity, and associated snapshots. [1] [2] [3] [4]LLM Controller Enhancements
controllerfunction insrc/llm.tsto define LLM controllers with support for execution logic and optional configuration. [1] [2] [3] [4]LlmControllerTransformerinsrc/transformers/features/llm/LlmControllerTransformer.tsfor handling LLM controller transformations, including validation and property assignments.LlmControllerTransformerinto the transformation pipeline by updatingCallExpressionTransformer.tsto include thecontrollerfunctor. [1] [2]Transformer Logic Improvements
LlmApplicationTransformerto modularize and improve the decomposition logic for LLM applications, enabling better reuse and error handling. [1] [2]ExpressionFactoryto support optional type parameters in theselfCallmethod, improving its flexibility. [1] [2]Test Suite Updates
ILlmApplicationusage withILlmControllerintest-esm/generate/input/index.tsandtest-esm/generate/output/index.ts. [1] [2] [3] [4] [5] [6] [7]Versioning
9.3.0-dev.20250511inpackage.json.