Close #1568: native type from @types/node
#1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/factories/internal/metadata/iterate_metadata_native.ts:121
- The condition in getNativeName may lead to incorrect slicing if the expected '"."' substring is not found (i.e. indexOf returns -1). Consider verifying the result of name.indexOf('"."', 1) before slicing to avoid potential errors.
if (name.startsWith('"') && name.slice(0).includes('"."'))
commit: |
@types/node@types/node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve functionality and add new features. The most important changes include a version update in
package.json, a refactor initerate_metadata_native.ts, and a new test case for native class handling.Version update:
package.json: Updated the version from9.1.0to9.1.1.Refactors and new functions:
src/factories/internal/metadata/iterate_metadata_native.ts: Refactored thenamevariable assignment to use the newgetNativeNamefunction. Added thegetNativeNamefunction to handle name processing. [1] [2]New test case:
test/src/features/issues/test_issue_1588_native_class_from_node.ts: Added a new test case to validate the handling of native classesBlobandFilefrom thenode:buffermodule.