Add 'equals' property to LLM schema composers and update validation tests #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an optional equals property to the schema composer interfaces for multiple LLM providers and improves validation test strictness. The changes enhance the parameter separation functionality across different LLM schema composers by introducing consistent interface support for equals-based operations.
- Added optional
equalsproperty to four LLM schema composers (Claude, DeepSeek, Gemini, Llama) - Enhanced test validation by re-enabling stricter error checking logic
- Updated package version for development build
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump for development build |
| src/composers/llm/ClaudeSchemaComposer.ts | Added optional equals property to separateParameters interface |
| src/composers/llm/DeepSeekSchemaComposer.ts | Added optional equals property to separateParameters interface |
| src/composers/llm/GeminiSchemaComposer.ts | Added optional equals property to separateParameters interface |
| src/composers/llm/LlamaSchemaComposer.ts | Added optional equals property to separateParameters interface |
| test/src/features/llm/application/validate_llm_application_separateEquals.ts | Re-enabled comprehensive error validation checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
package.jsonfile and introduces a newequalsproperty across multiple schema composers in the codebase. Additionally, it refines a test validator to ensure stricter validation logic.Version update:
package.json: Updated the version from4.6.0-dev.20250721to4.6.0-dev.20250721-3.New
equalsproperty:src/composers/llm/ClaudeSchemaComposer.ts: Added the optionalequalsproperty to theseparateParametersmethod.src/composers/llm/DeepSeekSchemaComposer.ts: Added the optionalequalsproperty to theseparateParametersmethod.src/composers/llm/GeminiSchemaComposer.ts: Added the optionalequalsproperty to theseparateParametersmethod.src/composers/llm/LlamaSchemaComposer.ts: Added the optionalequalsproperty to theseparateParametersmethod.Test validation improvement:
test/src/features/llm/application/validate_llm_application_separateEquals.ts: Enhanced validation logic by re-enabling stricter checks forresult.errorswhenresult.successisfalse.