IGeminiSchema.title in description as JSDocTag.
#194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```txt Some description. @title some title ``` Also, this strategy would be adjusted to the `typia` too. `typia` will no more define `IJsonSchema.title` from description comment. It will compose `IJsonSchema.title` only by `@title` tag. ```typescript export interface Something { /** * The first line is not title. */ first: string; /** * The title only comes from JSDocTag like below. * * @title this is the title */ second: number; } ```
There was a problem hiding this comment.
Pull Request Overview
Updates the schema composer to derive JSON schema titles exclusively from JSDoc @title tags and bumps the package version.
- Replace prior title/description merging logic with a simple
@titletag appending. - Increment version in
package.jsonto 4.5.0.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/composers/llm/GeminiSchemaComposer.ts | Replace custom title-to-description logic with standardized @title tag |
| package.json | Bump package version from 4.4.1 to 4.5.0 |
IChatGptSchema.title in description as JSDocTag.IGeminiSchema.title in description as JSDocTag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this strategy would be adjusted to the
typiatoo.typiawill no more defineIJsonSchema.titlefrom description comment. It will composeIJsonSchema.titleonly by@titletag.