Fix discrimiantor mapping property of AI schemas #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves handling and validation of discriminator mappings in both LLM and ChatGPT schema composers, and bolsters test coverage for various vendors.
- Transform
discriminator.mappingentries into proper component schema references inLlmSchemaV3_1ComposerandChatGptSchemaComposer - Add new tests for
claudeanddeepseekvendors and extend validation logic to assert mapping paths - Update existing ChatGPT and LLM tests to verify both original and inverted
discriminator.mappingprefixes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/composers/llm/LlmSchemaV3_1Composer.ts | Enhance discriminator.mapping transformation to #/components/schemas/ |
| src/composers/llm/ChatGptSchemaComposer.ts | Add mapping conversion and wrap x-discriminator into a structured object |
| test/src/features/llm/schema/validate_llm_schema_discriminator.ts | Introduce tests for claude and deepseek, check mapping presence |
| test/src/features/llm/chatgpt/test_chatgpt_schema_discriminator.ts | Extend ChatGPT schema validation to include mapping assertions |
Comments suppressed due to low confidence (1)
src/composers/llm/ChatGptSchemaComposer.ts:608
- The discriminator object should use the standard
propertyNamefield (notproperty) to align with the OpenAPI specification. RenamepropertytopropertyNamefor correctness.
property: props.schema["x-discriminator"],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to schema composition and validation logic, focusing on improving the handling of
discriminatorproperties in JSON schemas. The changes ensure better support for mapping values and add comprehensive validation checks for schema integrity.Schema Composition Enhancements:
discriminatorhandling inChatGptSchemaComposer: Added support for mapping values in thediscriminatorproperty, ensuring mappings are transformed into appropriate schema references (#/components/schemas/...).discriminatorlogic inLlmSchemaV3_1Composer: Extended thediscriminatorhandling to include validation of mappings and filtering of schema references, ensuring compatibility with theunionstructure. [1] [2]Validation Logic Improvements:
test_chatgpt_schema_discriminator: Added checks for the presence and correctness ofdiscriminator.mapping, verifying that all mapping values start with#/$defs/or#/components/schemas/. [1] [2]validate_llm_schema_discriminator: Introduced new tests for additional vendors (claude,deepseek, and3.1) and enhanced validation ofdiscriminator.mappingfor schema integrity. [1] [2] [3]