Fix ClaudeSchemaComposer.invert() function bug for oneOf type.
#187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the bug in ClaudeSchemaComposer.invert() for handling oneOf schemas and enhances schema composition logic while adding comprehensive tests.
- Schema inversion logic now correctly handles oneOf scenarios.
- Comprehensive tests for schema validation are added.
- The package version is updated to reflect the changes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/src/executable/validate.ts | Adds detailed tests covering nested schemas and oneOf conditions. |
| src/composers/llm/LlmSchemaV3_1Composer.ts | Updates schema inversion logic to support oneOf schemas. |
| package.json | Bumps package version from 4.3.2 to 4.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the
@samchon/openapipackage, focusing on enhancing schema handling and adding comprehensive test cases. The key changes include a version bump, improvements to schema composition logic, and the addition of a detailed test for schema validation.Package Version Update:
package.json: Updated the package version from4.3.2to4.3.3to reflect the new changes.Schema Handling Enhancements:
src/composers/llm/LlmSchemaV3_1Composer.ts: Enhanced the schema composition logic by adding support foroneOfschemas in theLlmSchemaV3_1Composerclass. This ensures proper handling of schemas with multiple possible types.New Test for Schema Validation:
test/src/executable/validate.ts: Added a comprehensive test case to validate schemas using theClaudeSchemaComposerandOpenApiTypeChecker. The test includes a complex schema with nested objects, arrays, andoneOfconditions, ensuring robust validation of OpenAPI components.