Fix #184: mcp type error by post build script #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type error by introducing a new post-build script, updating dependencies, and correcting documentation references.
- Added a post-build script in build/post.ts to copy type definition files.
- Updated dependencies including TypeScript and @modelcontextprotocol/sdk.
- Corrected type reference comments in src/OpenApi.ts.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/OpenApi.ts | Updated documentation to reference IJsonSchema instead of IOpenAiSchema. |
| package.json | Updated version number, dependencies, and build script to run the post-build script. |
| build/post.ts | Added a post-build script to copy type definition files from src to lib. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new post-build script, updates dependencies, and makes a minor documentation correction. The most significant changes include the addition of a script to copy type definition files after the build process, updates to
typescriptand other dependencies, and a change in a type reference in the documentation.Build process enhancements:
build/post.tsto copy type definition files (IMcpLlmController.d.tsandIMcpLlmController.d.mts) from thesrcdirectory to thelibdirectory. This script is now invoked as part of thebuildprocess inpackage.json. [1] [2]Dependency updates:
typescriptfrom5.7.3to5.8.3inpackage.jsonandpnpm-lock.yaml. This includes updates to related dependencies such as@rollup/plugin-typescriptandtypedoc. [1] [2] [3]@modelcontextprotocol/sdkfrom1.11.1to1.11.4inpackage.jsonandpnpm-lock.yaml. [1] [2] [3]@types/node,ts-node, and several transitive dependencies such asajv,fast-deep-equal,fast-uri, andrequire-from-stringinpnpm-lock.yaml. [1] [2] [3] [4]Documentation correction:
src/OpenApi.tsfromIOpenAiSchematoIJsonSchemain comments, aligning the documentation with the actual type definitions.