New type ILlmController.
#180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new controller type containing not only `ILlmApplication`, but also executor of it.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces new controller interfaces for managing LLM function calling via MCP, HTTP, and TypeScript, while also updating dependencies to support these enhancements. Key changes include adding IMcpLlmController, ILlmController, and IHttpLlmController interfaces; updating documentation comments and type annotations; and bumping the @samchon/openapi version with new dependency additions.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/structures/IMcpLlmController.ts | Added MCP-based controller interface with improved examples |
| src/structures/ILlmSchema.ts | Updated template commentary for clarity in type description |
| src/structures/ILlmFunction.ts | Added template parameter documentation |
| src/structures/ILlmController.ts | Added TypeScript controller interface with executor details |
| src/structures/IHttpLlmController.ts | Added HTTP-based controller interface including connection options |
| src/index.ts | Exported new controller interfaces under the CONTROLLERS section |
| package.json | Updated version number and added new dependency (@modelcontextprotocol/sdk) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new controller type containing not only
ILlmApplication, but also executor of it.This pull request introduces several updates, including dependency additions, version updates, and the introduction of new controller interfaces for LLM function calling. These changes enhance the functionality and compatibility of the project while introducing new features for HTTP, MCP, and TypeScript-based controllers.
Dependency Updates and Additions
@samchon/openapipackage version to4.3.0-dev.20250511inpackage.json. Added the@modelcontextprotocol/sdkdependency with version^1.11.1. [1] [2]pnpm-lock.yaml, includingeventsource-parser@3.0.1,eventsource@3.0.7,express-rate-limit@7.5.0,pkce-challenge@5.0.0,zod@3.24.4, andzod-to-json-schema@3.24.5. These dependencies support new functionality and integrations. [1] [2] [3] [4]New Controller Interfaces
IHttpLlmControllerinterface for managing HTTP-based LLM function calling. This includes properties for protocol, application schema, and an optional custom executor function.ILlmControllerinterface for TypeScript-based LLM function calling, designed for managing class-based executors.IMcpLlmControllerinterface for MCP-based LLM function calling, integrating with the@modelcontextprotocol/sdkclient.Codebase Enhancements
src/index.tsfile to export the newly introduced controller interfaces (IHttpLlmController,ILlmController, andIMcpLlmController) under a new "CONTROLLERS" section.ILlmFunction.tsandILlmSchema.ts, by refining theModelparameter description. [1] [2]