Support MCP (Model Context Protocol). #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support validation feedback and model specification for MCP.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Model Context Protocol (MCP) and enhances LLM function-calling capabilities in the @samchon/openapi package by introducing new namespaces, interfaces, and updated schema conversion logic.
- Added the McpLlm namespace and new interfaces to handle MCP-based tools and functions.
- Improved OpenAPI V3.1 schema conversion to correctly resolve references.
- Included new test cases for validating MCP application behavior and schema references.
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/src/features/mcp/validate_mcp_application.ts | Added tests for validating MCP applications with various models. |
| test/src/features/mcp/test_mcp_schema_ref.ts | Introduced schema reference testing to ensure proper filtering and resolution. |
| src/structures/IMcpTool.ts | Defined the IMcpTool interface for MCP tools with associated schema definitions. |
| src/structures/IMcpLlmFunction.ts | Added MCP LLM function interface with validation features. |
| src/structures/IMcpLlmApplication.ts | Defined the MCP LLM application interface for aggregating functions and errors. |
| src/ILlmFunction.ts | Updated ILlmFunction interface to include separated parameters. |
| src/index.ts | Exported new MCP and related interfaces for external usage. |
| src/converters/OpenApiV3_1Emender.ts | Revised schema conversion functions to standardize $ref resolution. |
| src/McpLlm.ts | Implemented the MCP to LLM application conversion with error handling. |
| src/HttpLlm.ts | Updated documentation to reflect the new MCP-based composition approach. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
src/structures/IMcpTool.ts:47
- The term 'restict' appears to be a spelling error; please change it to 'restrict'.
* As MCP (Model Context Protocol) does not restict the JSON schema specification, `@samchon/openapi` has defined it to be universal
src/structures/IMcpLlmApplication.ts:22
- There is a spelling mistake in 'functi0on'; it should be 'function'.
* each function has its own {@link IMcpLlmFunction.validate} functi0on for correcting AI agent's mistakes, and this is the reason why
src/McpLlm.ts
Outdated
| [key, (props.options as any)?.[key] ?? value] as const, | ||
| ), | ||
| ), | ||
| maxLength: props.options?.maxLength ?? null, |
There was a problem hiding this comment.
The default for maxLength is set to null, but according to the IOptions type it should be a number; consider using a numeric default such as 64.
Suggested change
| maxLength: props.options?.maxLength ?? null, | |
| maxLength: props.options?.maxLength ?? 64, |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for MCP (Model Context Protocol) integration and enhances LLM function-calling capabilities in the @samchon/openapi package. It introduces new MCP namespaces and interfaces, updates OpenAPI V3.1 schema conversion utilities, and supplements the package with additional test cases to validate the new MCP functionalities.
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/src/features/mcp/validate_mcp_application.ts | Adds tests to validate MCP applications for various models. |
| test/src/features/mcp/test_mcp_schema_ref.ts | Introduces a test case to verify schema reference filtering in MCP. |
| src/structures/IMcpTool.ts | Defines the interface for MCP tools. |
| src/structures/IMcpLlmFunction.ts | Adds type definitions for MCP LLM functions. |
| src/structures/IMcpLlmApplication.ts | Defines the application interface for MCP-based LLM functions. |
| src/structures/ILlmFunction.ts | Enhances ILlmFunction interface with separated parameter support. |
| src/index.ts | Exports the new MCP namespaces and structures. |
| src/converters/OpenApiV3_1Emender.ts | Updates schema conversion functions for OpenAPI components and refs. |
| src/McpLlm.ts | Implements MCP-to-LLM application conversion with validation support. |
| src/HttpLlm.ts | Adjusts HTTP LLM application composition by enforcing a default maxLength. |
Files not reviewed (1)
- package.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support validation feedback and LLM model specification for MCP.
This pull request introduces a significant update to the
@samchon/openapipackage, focusing on adding support for MCP (Model Context Protocol) integration and enhancing the LLM (Large Language Model) function-calling capabilities. Key changes include the addition of theMcpLlmnamespace, new structures for MCP-based function handling, and updates to OpenAPI V3.1 schema conversion utilities. These changes aim to improve schema validation, function composition, and error handling for LLM applications.MCP Integration and LLM Enhancements:
McpLlmnamespace insrc/McpLlm.ts, which includes a newapplicationfunction for converting MCP documents into LLM function-calling applications. This includes support for schema validation, error handling, and context reduction strategies.IMcpLlmApplication,IMcpLlmFunction, andIMcpTool, which define the structure and metadata for MCP-based LLM functions and tools. These interfaces support validation and error reporting during function composition. [1] [2] [3]src/index.tsto export the newly added MCP-related namespaces and structures.OpenAPI V3.1 Schema Conversion Improvements:
convertComponentsandconvertSchemafunctions inOpenApiV3_1Emenderto enable external usage for schema conversion. [1] [2]$refand$recursiveRefattributes more robustly, ensuring proper resolution of references in OpenAPI schemas. [1] [2]Documentation and Test Additions:
test_mcp_schema_ref, to validate MCP schema references and ensure compatibility with LLM function calling.Miscellaneous Updates:
package.jsonversion from4.1.0to4.2.0to reflect the new features and improvements.HttpLlmnamespace to align with the new MCP-based approach.These updates collectively enhance the package's ability to handle MCP documents and improve the reliability of LLM function-calling workflows.