Perf(slice): Optimize iteration function parameters and add test cases #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the iteration function parameters in the UniqueBy, GroupByMap, and Keyify functions to use index access for collection elements. - Optimize parameter naming in the GroupByMap function to improve code readability. - Add test cases for the GroupByMap function to cover different types of inputs.
|
Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 18 18
Lines 3178 3179 +1
=======================================
+ Hits 2996 2997 +1
Misses 170 170
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UniqueBy,GroupByMap, andKeyifyfunctions to use index access for collection elements. See: Feature/contains iterate by index #428 feat: speed up loops by reducing allocations #475GroupByMapfunction to improve code readability. See: Implemented GroupByMap #443GroupByMapfunction to cover different types of inputs. See: Implemented GroupByMap #443