Conversation
DebuggingHere is the output of Scope ID: scope-id-123
Scope name: scope-child
Service: SERVICE-E
Service type: lazy
Service build time: 1s
Invoked: /home/samber/project/github.com/samber/do/di_explain_test.go:fakeProvider5:38
Dependencies:
* SERVICE-D from scope scope-child
* SERVICE-C1 from scope scope-child
* SERVICE-B from scope [root]
* SERVICE-A1 from scope [root]
* SERVICE-A2 from scope [root]
* SERVICE-C2 from scope scope-child
* SERVICE-B from scope [root]
* SERVICE-A1 from scope [root]
* SERVICE-A2 from scope [root]
Dependents:
* SERVICE-F from scope scope-child
* SERVICE-G from scope scope-childHere is the output of Scope ID: scope-id-root
Scope name: [root]
DAG:
\_ [root] (ID: scope-id-root)
* 😴 SERVICE-A1
* 😴 SERVICE-A2
* 😴 SERVICE-B
|
|
\_ scope-0 (ID: scope-id-0)
|
|
|\_ scope-1a (ID: scope-id-1a)
| * 😴 SERVICE-C1
| * 😴 SERVICE-C2
| * 😴 SERVICE-D
| * 😴 SERVICE-E
| * 🔁 SERVICE-EAGER-VALUE
| |
| |
| |\_ scope-2a (ID: scope-id-2a)
| | * 😴 SERVICE-LAZY-HEALTH 🏥
| | * 🏭 SERVICE-TRANSIANT-SIMPLE
| |
| |
| \_ scope-2b (ID: scope-id-2b)
| * 😴 SERVICE-LAZY-SHUTDOWN 🙅
|
|
\_ scope-1b (ID: scope-id-1b)
* 😴 SERVICE-FThe emoji prefix indicates the service is either Lazy, Eager, or Transiant. The EOL emoji indicates the service implements |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 88.91% 93.14% +4.23%
==========================================
Files 6 22 +16
Lines 433 2554 +2121
==========================================
+ Hits 385 2379 +1994
- Misses 40 140 +100
- Partials 8 35 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello, that's a really great news! Thanks a lot. go get github.com/samber/do@v2-🚀
go: github.com/samber/do@v2-🚀: invalid version: version "v2-🚀" invalid: disallowed version stringworkaround: |
|
It would be nice to provide context o healthcheck and shutdown. |
|
@danilobuerger can you elaborate on your use case? |
Sure, I want to provide a context to be able to use cancellation. |
|
My last workaround don't work anymore. I've followed this guide https://github.com/samber/do/blob/v2-%F0%9F%9A%80/MIGRATION-V1-TO-V2.md and also the v2 readme : https://github.com/samber/do/blob/v2-%F0%9F%9A%80/README.md |
|
I renamed the package Adding an emoji in the branch name was definitely a bad idea 😆 |
Not your fault, |
|
@samber, Since I've designed the ShutdownOnSignals* function to accommodate any signals, we've maintained the I therefore propose deleting What do you think about ? I feel that they are redundant |
|
One thing I noticed is that the pattern of Later this fails: |
|
@danilobuerger v2 will make it possible to respect this pattern: do.As[*engineServiceImplem, EngineService](injector)
// or
do.InvokeAs[EngineService](injector)See the function comments for the full explanation. |
|
Dear I owe you a sincere apology for the long delay in delivering this second major release. Over the past two years, my professional life has been complicated, and I wasn’t able to give do the attention it deserved. I know many of you have been waiting, and I am truly sorry for keeping you waiting this long. The good news is: during the last week I was finally able to dedicate daily focus to the project, and we’ve reached some exciting milestones:
Today, I’m very happy to share the first release candidate: v2.0.0-rc1 🎉 Important notes
👉 Please upgrade to v2.0.0-rc1, test it in your projects, and share feedback. Your contributions and patience mean a lot, and I want v2.0 to reflect the quality this community deserves fully. Thank you again for sticking with me on this journey. 😘 |
|
Thank you so much for all the effort you’ve put into this. I hope life is a bit easier for you now and that you’re finding some balance. It’s amazing that, even after a challenging couple of years, you’ve returned to give the project the attention it deserves. The community is really lucky to have your dedication. Can’t wait to test v2.0.0-rc1. Updating right now! |
Hi there 👋,
Over the past 18 months, many of you reported bugs or provided valuable feedback on various aspects of this project, such as error handling, debugging, invocation API, documentation, and more... Thanks for your contributions! 🙌
Work on this library has provided me with significant learning opportunities and now I believe it's time to advance this project further.
Most of the work for v2 has been done already. I'm targeting the end of
2023,2024, 2025 for a release. It will depend on additional requirements.Scope
This milestone will lead to major improvement: Scope.
A
Scopewas previously referred to as anInjectorand can be viewed as a module of an application, with restricted visibility. I advocate for each project possessing aRootScopefor common code, and shifting business logic to dedicatedScopes.The
Scopesare structured with a parent (RootScopeor otherScope), numerousServices, and potentially a few childrenScopesas well.RootScopeowns options and is the onlyScopethat supports cloning.Servicesfrom aScopecan invokeServicesavailable locally or in parentScopes. Therefore, a singleServicecan be instantiated many times in different branches of the Scope tree, without conflict.Scopewill be almost invisible to developers: services will keep usingInjectorAPI without awareness of the underlying implementation, whether it's aRootScope,ScopeorVirtualScope.A chain of
Serviceinvocation will instantiate manyVirtualScope, in order to track dependency cycles.A debugging toolchain has been added to illustrate the service dependency chain and Scope tree.
Checklist
The library has been almost entirely recoded, but most of do@v1 API has been preserved (see breaking changes below).
Providers-> transformed into GoerrorServiceinvocation (not visible to developers for now)// @TODOin the code/v2suffix (and everywhere in the doc)To be challenged
Serviceinvocation based on Go field tags (discussed in [proposal] Auto magically inject services #28)Servicealiasing (discussed in Is there an equivalent to dig.As() ? #41 & Anonymous Invocation #25)Healthcheck and shutdown timeout-> passcontext.WithTimeout(10*time.Second)insteadShutdown timeout at service levelslogas logger (breaking change)Export of service DAG to dot files?More existing issues might be added to the v2 milestone.
Documentation
Testing
Code coverage has been improved compared to v1. 😍
// @TODOin xxx_test.go filesCoverage:
Breaking changes
Injectorstruct turned into an interface 😕ListProvidedServicesandListInvokedServicesnow return 2do.Edgearrays.*mypkg.MyService->*github.com/samber/example.MyService.injector.ShutdownOnSignalsandinjector.ShutdownOnSIGTERMnow return (os.Signal, error)If you consider the API must be improved, please write a comment on this issue. No breaking change will be done in v2 minor releases. And I hope v2 is going to be the last major version.