setup bundled build #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional dependency too
seems like all the scripts assume the submodule exists but its was being gitignored incorrectly
shell early exit and some conditional compilation issues
bash -e is not valid. https://explainshell.com/explain/1/bash i'm guessing this is supposed to actually be set -e or something removing it everywhere
if there is a need for these to be duplicated, we should share them instead i think all this stuff should go into a makefile or something which composes a bit better but this works for now
this is a holdover from rustqlite https://github.com/rusqlite/rusqlite/blob/eff71a449723de6106dbe89a69db724af967905b/libsqlite3-sys/build.rs#L521-L528 we don't need it here as we don't have this block https://github.com/rusqlite/rusqlite/blob/eff71a449723de6106dbe89a69db724af967905b/libsqlite3-sys/build.rs#L607-L615
i want to comment out the test so i can use this even if the tests are failing
this is breaking everything
|
Thanks @0xcaff! I will just merge this and continue working in samansmink:poc-rust-c-extension-api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok, initial attempt at setting up a bundled build. the entrypoint to generate the bundled assets is
crates/libduckdb-sys/upgrade.sh. see the commit messages for detailed information about each of the changesoutstanding issues
it seems like duckdb_extension.h is not included in the output from build_package.py https://github.com/duckdb/duckdb/blob/e4f424b31b811973b197534bcabe252a7d54849f/scripts/package_build.py#L216it is the git submodule updating was brokenthere's a few outstanding test failures
testing
crates/libduckdb-sys/upgrade.sh