fix 32-bit compilation on old Glib #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In which issue is this included? |
No, this issue is for 2.10.3. for 2.11 we fix 2.64 as the minimum Glib version, which is already the case for the 64 bit version. |
|
To be clear, now (already released 2.10.2):
It should stays the same in 2.10.3. For 2.11 both will have 2.64 as the minimum Glib version. |
RayOei
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 64-bit released version of rmlint already uses G_SIZEOF_MEMBER, that is available on 2.64. So in practice, rmlint 2.10.2 has already 2.64 as a minimum version.
However, the 32-bit code does not use this macro, so it still compiles under older Glib on 32-bit. Let's not break user compatibility for 2.10.
This will be properly fixed in 2.11.