Skip to content

set the minimum Glib version to 2.64 #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

set the minimum Glib version to 2.64 #707

merged 1 commit into from
Mar 20, 2025

Conversation

vassilit
Copy link
Collaborator

@vassilit vassilit commented Mar 9, 2025

No description provided.

@vassilit vassilit added this to the 2.11.0 Evolving Echidna milestone Mar 9, 2025
@fermino fermino mentioned this pull request Mar 10, 2025
Merged
This was referenced Mar 17, 2025
Merged
Merged
@vassilit
Copy link
Collaborator Author

vassilit commented Mar 20, 2025 •
edited
Loading

@RayOei I even wonder if we should not release this as well for 2.10.3.
Having different Glib requirement for 32-bit and 64-bit users is a bit strange.

With 2.64, both 32 and 64 bit works well.

https://repology.org/project/glib/versions

@vassilit
Copy link
Collaborator Author

This will better reflect the fact that 64-bit version already, including 2.10.2, requires glibc 2.64.

@RayOei
Copy link
Collaborator

RayOei commented Mar 20, 2025

release this as well for 2.10.3.

Be my guest.

@vassilit
set the minimum Glib version to 2.64
8b0a0e9 
Due to the usage of G_SIZEOF_MEMBER (64-bit version only).
@vassilit
Copy link
Collaborator Author

@RayOei The warning should have disappeared.

RayOei
RayOei approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@RayOei RayOei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds without glib warnings on

  • Ubuntu 24.04
  • macOS 15.3.2
    👍

@RayOei RayOei merged commit 90bcc7a into master Mar 20, 2025
1 check passed
@vassilit vassilit deleted the glib branch March 20, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayOei RayOei RayOei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.3 Ludicrous Lemur Bugfixes
Development

Successfully merging this pull request may close these issues.
2 participants
@vassilit @RayOei