Skip to content

[rebase] sh format: improve stampfile handling #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

vassilit
Copy link
Collaborator

@vassilit vassilit commented Mar 3, 2025

  • mktemp in /tmp
  • don't assume $0 is a file
  • remove stampfiles at exit
  • don't create stampfiles if -n is passed

Closes #554
Rebase of #556

- mktemp in /tmp
- don't assume $0 is a file
- remove stampfiles at exit
- don't create stampfiles if -n is passed

Closes #554
@vassilit vassilit changed the title sh format: improve stampfile handling [rebase] sh format: improve stampfile handling Mar 3, 2025
Copy link
Collaborator

@RayOei RayOei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RayOei RayOei merged commit d328a41 into master Mar 3, 2025
1 check passed
@RayOei RayOei added this to the 2.10.3 Ludicrous Lemur Bugfixes milestone Mar 3, 2025
@RayOei
Copy link
Collaborator

RayOei commented Mar 3, 2025

I already merged this one but realised: shouldn't we add a modified CHANGELOG with these PR's? Seems logical to include?

@vassilit
Copy link
Collaborator Author

vassilit commented Mar 3, 2025

I already merged this one but realised: shouldn't we add a modified CHANGELOG with these PR's? Seems logical to include?

CHANGELOG could be updated by batch before release.

@vassilit vassilit deleted the stampfile-fixes branch March 11, 2025 18:04
@vassilit vassilit restored the stampfile-fixes branch March 11, 2025 18:04
@vassilit vassilit deleted the stampfile-fixes branch March 20, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STAMPFILE for maintaining directory timestamps is not deleted when executing rmlint.sh using -n (dry run)
3 participants