Skip to content

json: properly escape cwd and args #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

json: properly escape cwd and args #691

merged 1 commit into from
Mar 3, 2025

Conversation

vassilit
Copy link
Collaborator

@vassilit vassilit commented Mar 2, 2025 •
edited
Loading

as they may contain any char but \0.

Closes: #682

@vassilit vassilit added the bug label Mar 2, 2025
@vassilit vassilit self-assigned this Mar 2, 2025
@vassilit vassilit linked an issue Mar 2, 2025 that may be closed by this pull request
rmlint writes non-compliant JSON if quotes are passed at the command line #682
Closed
@vassilit vassilit added this to the 2.10.3 To Be Determined milestone Mar 2, 2025
@vassilit
json: properly escape cwd and args
afe190a 
as they may contain any char but \0.
@vassilit vassilit force-pushed the 682-rmlint-writes-non-compliant-json-if-quotes-are-passed-at-the-command-line branch from 56fe6a1 to afe190a Compare March 2, 2025 20:48
@vassilit
Copy link
Collaborator Author

vassilit commented Mar 2, 2025

This is better fixed in develop, by using JSON-Glib (but --without-json-glib may have to disappear), but for 2.10.3, this bug fix is enough.

Related: #480

RayOei
RayOei approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@RayOei RayOei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RayOei RayOei merged commit 4934861 into master Mar 3, 2025
1 check passed
@vassilit vassilit deleted the 682-rmlint-writes-non-compliant-json-if-quotes-are-passed-at-the-command-line branch March 3, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RayOei RayOei RayOei approved these changes

Assignees

@vassilit vassilit

Labels
bug
Projects
None yet
Milestone
2.10.3 Ludicrous Lemur Bugfixes
Development

Successfully merging this pull request may close these issues.

rmlint writes non-compliant JSON if quotes are passed at the command line
2 participants
@vassilit @RayOei