Add test cases for editor based extensions scanning #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
========================================
+ Coverage 8.13% 8.15% +0.02%
========================================
Files 278 278
Lines 45874 45881 +7
========================================
+ Hits 3732 3742 +10
+ Misses 41866 41864 -2
+ Partials 276 275 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive tests for scanning VSIX extensions across different editor distributions and tightens path validation.
- Introduces table-driven tests for each supported editor and a combined multi-editor test
- Adds a test for invalid paths to ensure unsupported directories produce an error
- Updates
NewVSIXExtReaderto return an error on unsupported editor paths - Supplies JSON fixtures for VSCode, VSCodium, Cursor, and Windsurf under
pkg/readers/fixtures/vsix
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/readers/vsix_ext_reader_test.go | Add table-driven tests for single/multiple editors and invalid path |
| pkg/readers/vsix_ext_reader.go | Validate input paths in NewVSIXExtReader, error on unsupported path |
| pkg/readers/fixtures/vsix/.vscode/extensions/extensions.json | Add VSCode extensions fixture |
| pkg/readers/fixtures/vsix/.vscode-oss/extensions/extensions.json | Add VSCodium extensions fixture |
| pkg/readers/fixtures/vsix/.cursor/extensions/extensions.json | Add Cursor extensions fixture |
| pkg/readers/fixtures/vsix/.windsurf/extensions/extensions.json | Add Windsurf extensions fixture |
Comments suppressed due to low confidence (3)
pkg/readers/vsix_ext_reader_test.go:19
- [nitpick] The test function name uses "VSCodeExtReader" but the reader is named "VSIXExtReader"; consider renaming it to "TestVSIXExtReaderForAllEditors" for consistency.
func TestVSCodeExtReaderForAllEditors(t *testing.T) {
pkg/readers/vsix_ext_reader_test.go:128
- Consider asserting on the specific error message with something like
assert.Contains(t, err.Error(), "unsupported editor path")to verify the correct error is returned.
assert.Error(t, err)
|
Please share your thoughts on this: #540 (comment) |
abhisek
approved these changes
Jul 18, 2025
|
@Sahilb315 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #540