Skip to content

Conversation

Sahilb315
Copy link
Contributor

Fixes #530

Copilot

This comment was marked as outdated.

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes missing coverage. Please review.

Project coverage is 8.19%. Comparing base (06988f9) to head (719dfb0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reporter/github_sync_resolver.go 50.00% 14 Missing ⚠️
scan.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #539      +/-   ##
========================================
+ Coverage   8.13%   8.19%   +0.05%     
========================================
  Files        278     279       +1     
  Lines      45874   45915      +41     
========================================
+ Hits        3732    3762      +30     
- Misses     41866   41878      +12     
+ Partials     276     275       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sahilb315 Sahilb315 force-pushed the feat/#530-sync-reporter-github branch from cf752bb to c2a6810 Compare July 14, 2025 17:47
@Sahilb315 Sahilb315 self-assigned this Jul 14, 2025
@Sahilb315 Sahilb315 force-pushed the feat/#530-sync-reporter-github branch from c2a6810 to b7a1e66 Compare July 15, 2025 13:32
@Sahilb315 Sahilb315 marked this pull request as ready for review July 15, 2025 16:40
@Sahilb315 Sahilb315 requested review from abhisek and Copilot July 16, 2025 15:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GitHub Actions support to the sync reporter by implementing a GitHub Actions-specific environment resolver. The changes enable automatic detection of GitHub Actions execution context and extraction of relevant metadata like repository URL, git references, and trigger types.

  • Introduces a new GitHub Actions environment resolver that reads GitHub-specific environment variables
  • Updates the sync reporter to automatically detect and use GitHub Actions context when available
  • Adds comprehensive test coverage for the new environment resolver functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
scan.go Updates sync reporter initialization to use the new environment resolver factory function
pkg/reporter/sync.go Adds factory function to automatically select appropriate environment resolver based on context
pkg/reporter/github_sync_resolver.go Implements GitHub Actions-specific environment resolver with mapping of GitHub events to tool triggers
pkg/reporter/sync_test.go Adds comprehensive test coverage for the new environment resolver functionality

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sahil Bansal <bansalsahil315@gmail.com>
@Sahilb315 Sahilb315 requested a review from abhisek July 17, 2025 10:39
@Sahilb315 Sahilb315 changed the title Add github actions sync reporter Add github actions sync resolver Jul 17, 2025
@abhisek
Copy link
Member

abhisek commented Jul 18, 2025

@Sahilb315 The tests are failing for this.

@Sahilb315
Copy link
Contributor Author

@Sahilb315 The tests are failing for this.

Ohh.. they are passing locally but failing here because the env variables are set in the CI/CD runner & can access the variables.

@abhisek Fixed it

@abhisek abhisek merged commit 3d6d8ed into main Jul 21, 2025
9 checks passed
@abhisek abhisek deleted the feat/#530-sync-reporter-github branch July 21, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sync Reporter Environment Resolver for GitHub
2 participants