Support for local docker and tar images in container scanning. #497

KunalSin9h · 2025-05-28T08:47:46Z

fixes #491 #492

github-actions · 2025-05-28T08:49:02Z

vet Summary Report

This report is generated by vet

Policy Checks

✅ Vulnerability
✅ Malware
✅ License
✅ Popularity
❌ Maintenance
✅ Security Posture
✅ Threats

Malicious Package Analysis

Malicious package analysis was performed using SafeDep Cloud API

Malicious Package Analysis Report

Ecosystem	Package	Version	Status	Report
ECOSYSTEM_GO	go.opentelemetry.io/otel/trace	1.36.0	✅	🔗
ECOSYSTEM_GO	github.com/moby/docker-image-spec	1.3.1	✅	🔗
ECOSYSTEM_GO	go.opentelemetry.io/otel/metric	1.36.0	✅	🔗
ECOSYSTEM_GO	github.com/moby/sys/sequential	0.6.0	✅	🔗
ECOSYSTEM_GO	github.com/docker/go-units	0.5.0	✅	🔗
ECOSYSTEM_GO	github.com/docker/docker	28.1.1+incompatible	✅	🔗
ECOSYSTEM_GO	go.opentelemetry.io/otel	1.36.0	✅	🔗
ECOSYSTEM_GO	github.com/moby/sys/atomicwriter	0.1.0	✅	🔗
ECOSYSTEM_GO	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp	0.61.0	✅	🔗
ECOSYSTEM_GO	golang.org/x/sys	0.33.0	✅	🔗

ℹ️ 10 packages have been actively analyzed for malicious behaviour.
✅ No malicious packages found.

Changed Packages

✅ [Go] go.opentelemetry.io/otel@1.36.0
✅ [Go] github.com/moby/sys/atomicwriter@0.1.0
✅ [Go] golang.org/x/sys@0.33.0
⚠️ [Go] github.com/docker/go-units@0.5.0
⚠️ [Go] github.com/moby/docker-image-spec@1.3.1
✅ [Go] go.opentelemetry.io/otel/metric@1.36.0
✅ [Go] go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@0.61.0
✅ [Go] github.com/moby/sys/sequential@0.6.0
✅ [Go] github.com/docker/docker@28.1.1+incompatible
✅ [Go] go.opentelemetry.io/otel/trace@1.36.0

Policy Violations

Packages Violating Policy

[Go] `github.com/docker/go-units@0.5.0` 🔗

➡️ Found in manifest go.mod
⚠️ Component appears to be unmaintained

[Go] `github.com/moby/docker-image-spec@1.3.1` 🔗

➡️ Found in manifest go.mod
⚠️ Component appears to be unmaintained

pkg/readers/container_image_reader.go

codecov · 2025-05-28T09:00:56Z

Codecov Report

Attention: Patch coverage is 11.51079% with 123 lines in your changes missing coverage. Please review.

Project coverage is 16.40%. Comparing base (a2c003f) to head (2d988f1).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/readers/container_image_resolve_workflow.go	0.00%	78 Missing ⚠️
pkg/readers/container_image_reader.go	29.62%	37 Missing and 1 partial ⚠️
scan.go	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   16.46%   16.40%   -0.07%     
==========================================
  Files         161      162       +1     
  Lines       16187    16290     +103     
==========================================
+ Hits         2665     2672       +7     
- Misses      13318    13413      +95     
- Partials      204      205       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pkg/common/utils/log_error.go

pkg/readers/container_image_reader.go

pkg/readers/container_image_resolve_workflow.go

test/scenarios/scenario-12-image-scan-local-docker-image.sh

test/scenarios/scenario-14-image-scan-with-remote-registry.sh

pkg/readers/container_image_resolve_workflow.go

* chore: Misc cleanup * fix: Bug with docker image resolver * fix: Error msg * chore: Improve debug logging for docker enumeration * chore: Improve debug logging for docker enumeration

KunalSin9h · 2025-05-29T17:04:24Z

@abhisek tests passed

KunalSin9h added 7 commits May 28, 2025 11:35

refactor: convert current image resolution into workflow pattern

0f6679b

feat: image from local tarball folder

20e103c

feat: image from local docker catalog

8a1d4c7

refacot: decompose docker image catalog resolver into multiple functions

bbed3d5

refactor: using utilit function for logging and return error

73df24b

feat: remove tem tar dir after image obj is created

b976710

refactor: handle empty nil error in log and error funciton

e420dfd

KunalSin9h commented May 28, 2025

View reviewed changes

pkg/readers/container_image_reader.go Outdated Show resolved Hide resolved

KunalSin9h added 2 commits May 28, 2025 14:23

removed local image not supported test

ea4d2f1

fix: error fmt.Errorf with non-constant values

d528283

KunalSin9h added 3 commits May 28, 2025 14:44

go mod tidy

d5668df

fix: linter unreachable code

b8fbaf3

refactor: removed unwanted parameter

42709e8

KunalSin9h requested a review from abhisek May 28, 2025 09:32

KunalSin9h added 3 commits May 28, 2025 15:11

test: added scenerio for different image scan operations

0ea6c9e

fix: added scenario into all.sh

8be4496

fix: missed .sh extension for one entry

a8bee6e

abhisek reviewed May 28, 2025

View reviewed changes

KunalSin9h added 5 commits May 28, 2025 16:02

fix: test bad file path for local tar scan

88f20eb

remvoed logger and error combined function

d9d6641

refactor: using context form top of tree

8aebb71

feat: using custom error for image resolution unsupported

379df32

refactor: returning unsupported workflow error for each docker api fail

8eef76c

KunalSin9h requested a review from abhisek May 28, 2025 11:18

KunalSin9h changed the title ~~Feat/local image~~ Support for local docker and tar images in container scanning. May 28, 2025

abhisek reviewed May 28, 2025

View reviewed changes

KunalSin9h added 2 commits May 28, 2025 20:09

feat: added no-remote flag for disable remote fetch

40a1ca5

feat: --image-no-remote

f42644f

fix: test, creating temp files witn \/ causing issue

174cb72

KunalSin9h requested a review from abhisek May 28, 2025 15:43

KunalSin9h and others added 2 commits May 29, 2025 00:21

Merge branch 'main' into feat/local-image

ddbe079

chore: Misc cleanup for Container Image Resolver (#499)

2d988f1

* chore: Misc cleanup * fix: Bug with docker image resolver * fix: Error msg * chore: Improve debug logging for docker enumeration * chore: Improve debug logging for docker enumeration

abhisek approved these changes May 29, 2025

View reviewed changes

abhisek merged commit 49cc6ca into main May 29, 2025
8 of 11 checks passed

abhisek deleted the feat/local-image branch May 29, 2025 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support for local docker and tar images in container scanning. #497

Support for local docker and tar images in container scanning. #497

Uh oh!

KunalSin9h commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Changed Packages

Packages Violating Policy

[Go] `github.com/docker/go-units@0.5.0` 🔗

[Go] `github.com/moby/docker-image-spec@1.3.1` 🔗

Uh oh!

Uh oh!

codecov bot commented May 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KunalSin9h commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

Support for local docker and tar images in container scanning. #497

Support for local docker and tar images in container scanning. #497

Uh oh!

Conversation

KunalSin9h commented May 28, 2025

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

vet Summary Report

Policy Checks

Malicious Package Analysis

Changed Packages

Packages Violating Policy

[Go] github.com/docker/go-units@0.5.0 🔗

[Go] github.com/moby/docker-image-spec@1.3.1 🔗

Uh oh!

Uh oh!

codecov bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KunalSin9h commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

[Go] `github.com/docker/go-units@0.5.0` 🔗

[Go] `github.com/moby/docker-image-spec@1.3.1` 🔗

codecov bot commented May 28, 2025 •

edited

Loading