refactor: Sync reporter to allow env resolver adapter #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vet Summary ReportThis report is generated by vet Policy Checks
Malicious Package AnalysisMalicious package analysis was performed using SafeDep Cloud API Malicious Package Analysis Report
Changed PackagesChanged Packages
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the sync reporter to support an environment resolver adapter. Key changes include:
- Adding a new SyncReporterEnvResolver interface and its default implementation.
- Updating reporter instantiation in scan.go and sync.go to inject an env resolver.
- Extending tests in pkg/reporter/sync_test.go to cover scenarios with resolved environment attributes and updating dependency versions in go.mod.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scan.go | Updated reporter initialization to include the environment resolver adapter. |
| pkg/reporter/sync_test.go | Added testEnvResolver and expanded tests for the createToolSessionRequestForProjectVersion function. |
| pkg/reporter/sync.go | Introduced the SyncReporterEnvResolver interface with a default implementation and refactored reporter creation accordingly. |
| go.mod | Updated dependency versions. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
+ Coverage 16.21% 16.46% +0.24%
==========================================
Files 161 161
Lines 16160 16187 +27
==========================================
+ Hits 2621 2665 +44
+ Misses 13335 13318 -17
Partials 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3fd5d5c to
b4cc31f
Compare
Sahilb315
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.