Ackee[M1]: Deprecate createProxyWithCallback Function
#955
+7
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to front-run a `createProxyWithCallback` deployment using `createProxyWithNonce` with a crafted `saltNonce`. This would make it so the proxy would be deployed, but the callback not executed. Since this method is not in use, we are deciding to deprecate it. Alternatively, it would be possible to bring it back by using a different `CREATE2` salt computation method in case this method is needed in the future.
mmv08
approved these changes
May 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to front-run a
createProxyWithCallbackdeployment usingcreateProxyWithNoncewith a craftedsaltNonce. This would make it so the proxy would be deployed, but the callback not executed. Since this method is not in use, we are deciding to deprecate it.Alternatively, it would be possible to bring it back by using a different
CREATE2salt computation method in case this method is needed in the future. Integrations that require a specific call at deployment call can use thesetupparameters with atoanddata, which would guarantee a callback at deployment time.