Skip to content

Removing payable #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

Removing payable #817

merged 1 commit into from
Aug 28, 2024

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Aug 28, 2024

This PR removes the payable casting based on the comment #815 (comment)

@remedcu remedcu self-assigned this Aug 28, 2024
@remedcu remedcu mentioned this pull request Aug 28, 2024
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10597497903

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.196%
Totals Coverage Status
Change from base Build 10522042743: 0.0%
Covered Lines: 386
Relevant Lines: 401
💛 - Coveralls

@remedcu remedcu merged commit b541cd7 into release/v1.4.1-2 Aug 28, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@nlordell nlordell deleted the remove-payable branch September 10, 2024 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell Awaiting requested review from nlordell

@akshay-ap akshay-ap Awaiting requested review from akshay-ap

1 more reviewer

@mmv08 mmv08 mmv08 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@remedcu remedcu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remedcu @coveralls @mmv08