[Certora Audit] G07. Use a mask instead of shifting left and right #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
contracts/handler/extensibledirectory, specifically in theMarshalLib.solandSignatureVerifierMuxer.solfiles. The changes focus on improving the handling of data and selectors within assembly code blocks to decrease gas usage.Improvements to data handling and selector extraction:
contracts/handler/extensible/MarshalLib.sol: Modified the way thehandleris extracted fromdataby using a bitwise AND operation to ensure proper extraction of the handler address. [1] [2]contracts/handler/extensible/SignatureVerifierMuxer.sol: Changed the extraction ofsigSelectorfromcalldataloadto use a bitwise AND operation for more accurate and secure selector extraction.