add a new API to report report feature states #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping? |
|
LGTM, could you rebase it. |
on it, thanks! |
When inspecting features, the current API reports only if each feature is active. Client applications, especially those consuming the output of `ethtool -k [iface]` also want to know if a feature can actually be enabled or not. Examples: - https://github.com/jaypipes/ghw/blob/main/README.md#network -https://github.com/jaypipes/ghw/blob/main/pkg/net/net_linux.go#L161 This information is already available but is not exposed to the API. So, add a new API to export all the flags. We add a new API instead of changing the existing one to avoid breaking the backward compatibility. Signed-off-by: Francesco Romani <fromani@redhat.com>
265375d to
10f3ba2
Compare
|
rebased, tests pass locally |
|
Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting features, the current API reports only if each feature is active.
Client applications, especially those consuming the output of
ethtool -k [iface]also want to know if a feature canactually be enabled or not. Examples:
-https://github.com/jaypipes/ghw/blob/main/pkg/net/net_linux.go#L161
This information is already available but is not exposed to the API.
So, add a new API to export all the flags. We add a new API instead of changing the existing one to avoid breaking the backward
compatibility.
Closes: #50
Signed-off-by: Francesco Romani fromani@redhat.com