Skip to content

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Apr 13, 2025

long awaited update, all patches are in, also, works on the latest Apple clang 17.0.0.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase
Copy link
Member Author

dimpase commented Apr 13, 2025

@kiwifb - can you take a look? Especially as you took part in givaro update.

@behackl - this should cover the givaro part of your patches for clang 17

Copy link

github-actions bot commented Apr 13, 2025

Documentation preview for this PR (built with commit f9d47ec; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member Author

dimpase commented Apr 17, 2025

ping?

@tscrim
Copy link
Collaborator

tscrim commented Apr 18, 2025

@isuruf Is that a positive review?

@isuruf
Copy link
Member

isuruf commented Apr 18, 2025

Yes

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 20, 2025
sagemathgh-39936: update givaro to 4.2.1
    
long awaited update, all patches are in, also, works on the latest Apple
clang 17.0.0.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39936
Reported by: Dima Pasechnik
Reviewer(s): Isuru Fernando
@dimpase dimpase mentioned this pull request Apr 20, 2025
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 21, 2025
sagemathgh-39936: update givaro to 4.2.1
    
long awaited update, all patches are in, also, works on the latest Apple
clang 17.0.0.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39936
Reported by: Dima Pasechnik
Reviewer(s): Isuru Fernando
@vbraun vbraun merged commit 3678dc6 into sagemath:develop Apr 29, 2025
15 of 34 checks passed
@enriqueartal
Copy link
Contributor

Should the positive review be added again?

@dimpase
Copy link
Member Author

dimpase commented May 2, 2025

it's already merged in the beta, so it's not important

vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17
    
Linbox needs patches for gcc-15 and Apple clang-17

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#39936: givaro update to 4.2.1
    
URL: sagemath#39985
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
sagemathgh-39977: allow gcc-15 from the system
    
Fedora 42 comes with gcc-15 by default, so it should be allowed, as
asked on [sage-release](https://groups.google.com/g/sage-
release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ)


## 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- sagemath#39985 : linbox patches
- sagemath#39936 : givaro 4.2.1
    
URL: sagemath#39977
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17
    
Linbox needs patches for gcc-15 and Apple clang-17

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#39936: givaro update to 4.2.1
    
URL: sagemath#39985
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
sagemathgh-39977: allow gcc-15 from the system
    
Fedora 42 comes with gcc-15 by default, so it should be allowed, as
asked on [sage-release](https://groups.google.com/g/sage-
release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ)


## 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- sagemath#39985 : linbox patches
- sagemath#39936 : givaro 4.2.1
    
URL: sagemath#39977
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17
    
Linbox needs patches for gcc-15 and Apple clang-17

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#39936: givaro update to 4.2.1
    
URL: sagemath#39985
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2025
sagemathgh-39977: allow gcc-15 from the system
    
Fedora 42 comes with gcc-15 by default, so it should be allowed, as
asked on [sage-release](https://groups.google.com/g/sage-
release/c/iBMmwCCKJuM/m/h4EXk5nUDAAJ)


## 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- sagemath#39985 : linbox patches
- sagemath#39936 : givaro 4.2.1
    
URL: sagemath#39977
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2025
sagemathgh-39985: linbox patches for gcc-15 and Apple clang-17
    
Linbox needs patches for gcc-15 and Apple clang-17

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#39936: givaro update to 4.2.1
    
URL: sagemath#39985
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants