Skip to content

add parameter immutable to GraphQuery src/sage/graphs/graph_database.py #39923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dcoudert
Copy link
Contributor

Following discussions in #39177, we add the option to return immutable graphs when querying the graph database.

We also exchange some code between methods query_iterator and get_graphs_list to avoid the creation of a list when we only want to iterate over the answers.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit a30d802; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, merci ; doctests failures in CI are not related

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 30, 2025
sagemathgh-39923: add parameter immutable to GraphQuery `src/sage/graphs/graph_database.py`
    
Following discussions in sagemath#39177, we add the option to return immutable
graphs when querying the graph database.

We also exchange some code between methods `query_iterator` and
`get_graphs_list` to avoid the creation of a list when we only want to
iterate over the answers.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39923
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request May 1, 2025
sagemathgh-39923: add parameter immutable to GraphQuery `src/sage/graphs/graph_database.py`
    
Following discussions in sagemath#39177, we add the option to return immutable
graphs when querying the graph database.

We also exchange some code between methods `query_iterator` and
`get_graphs_list` to avoid the creation of a list when we only want to
iterate over the answers.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39923
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2025
sagemathgh-39923: add parameter immutable to GraphQuery `src/sage/graphs/graph_database.py`
    
Following discussions in sagemath#39177, we add the option to return immutable
graphs when querying the graph database.

We also exchange some code between methods `query_iterator` and
`get_graphs_list` to avoid the creation of a list when we only want to
iterate over the answers.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39923
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
sagemathgh-39923: add parameter immutable to GraphQuery `src/sage/graphs/graph_database.py`
    
Following discussions in sagemath#39177, we add the option to return immutable
graphs when querying the graph database.

We also exchange some code between methods `query_iterator` and
`get_graphs_list` to avoid the creation of a list when we only want to
iterate over the answers.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39923
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
sagemathgh-39923: add parameter immutable to GraphQuery `src/sage/graphs/graph_database.py`
    
Following discussions in sagemath#39177, we add the option to return immutable
graphs when querying the graph database.

We also exchange some code between methods `query_iterator` and
`get_graphs_list` to avoid the creation of a list when we only want to
iterate over the answers.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39923
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit 10f0473 into sagemath:develop May 11, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants