add add_entry and anti_restrict methods to SkewTableau #39918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/sage/combinat/tableau.py:3193
- The new condition in add_entry adds a constraint that may unintentionally block valid cells in edge cases. Please verify that this additional check correctly handles all tableau shapes and add a comment explaining its intent.
if c == len(tab_r) and (r == 0 or len(tab_r) < len(tab[r-1])):
trevorkarn
reviewed
Apr 16, 2025
trevorkarn
reviewed
Apr 16, 2025
trevorkarn
reviewed
Apr 16, 2025
| if r == len(tab) and c == 0: | ||
| tab.append([m]) | ||
| else: | ||
| raise IndexError('%s is not an addable cell of the tableau' % ((r, c),)) |
There was a problem hiding this comment.
Maybe check here for bottom left cell None (per our in-person conversation)
There was a problem hiding this comment.
This ended up being not too bad to implement in full generality (instead of raising a NotImplementedError like we previously discussed).
trevorkarn
reviewed
Apr 16, 2025
trevorkarn
reviewed
Apr 16, 2025
…ing new skewtableau
|
@jmcdonough98 as long as your tests pass locally, you can set to positive review |
trevorkarn
approved these changes
May 14, 2025
|
@trevorkarn all tests pass on my machine, but github is not letting me change PR labels. I think I don't have permission. |
|
merge conflict, please fix |
|
Thanks @vbraun. @jmcdonough98 Do you need help with this? |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 24, 2025
sagemathgh-39918: add add_entry and anti_restrict methods to SkewTableau <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> `add_entry` and `anti_restrict` are already existing methods in `Tableau`, but they also make sense for `SkewTableau`. This PR ports these methods to `SkewTableau`, and adds a simple check to `add_entry` to avoid trying to construct a new tableau when the given cell is too large. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies None <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39918 Reported by: Joe McDonough Reviewer(s): Copilot, Joe McDonough, trevorkarn
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 26, 2025
sagemathgh-39918: add add_entry and anti_restrict methods to SkewTableau <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> `add_entry` and `anti_restrict` are already existing methods in `Tableau`, but they also make sense for `SkewTableau`. This PR ports these methods to `SkewTableau`, and adds a simple check to `add_entry` to avoid trying to construct a new tableau when the given cell is too large. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies None <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39918 Reported by: Joe McDonough Reviewer(s): Copilot, Joe McDonough, trevorkarn
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-39918: add add_entry and anti_restrict methods to SkewTableau <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> `add_entry` and `anti_restrict` are already existing methods in `Tableau`, but they also make sense for `SkewTableau`. This PR ports these methods to `SkewTableau`, and adds a simple check to `add_entry` to avoid trying to construct a new tableau when the given cell is too large. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies None <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39918 Reported by: Joe McDonough Reviewer(s): Copilot, Joe McDonough, trevorkarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_entryandanti_restrictare already existing methods inTableau, but they also make sense forSkewTableau.This PR ports these methods to
SkewTableau, and adds a simple check toadd_entryto avoid trying to construct a new tableau when the given cell is too large.📝 Checklist
⌛ Dependencies
None