cli: remove default from -n argument #39900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 160c6f8; changes) is ready! 🎉 |
tobiasdiez
approved these changes
May 10, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2025
sagemathgh-39900: cli: remove default from -n argument Without this, calling any command line argument (currently only `sage -v`) will launch the notebook, because `args.notebook` evaluates to `True` in https://github.com/sagemath/sage/blob/10.7.beta0/src/sage/cli/ __init__.py#L42 The `const` option already takes care of providing a default value for `-n`. URL: sagemath#39900 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, calling any command line argument (currently only
sage -v) will launch the notebook, becauseargs.notebookevaluates toTruein https://github.com/sagemath/sage/blob/10.7.beta0/src/sage/cli/__init__.py#L42The
constoption already takes care of providing a default value for-n.