Skip to content

Run python3 directly instead of sage -python in sage/tests/startup.py #39997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2025

Conversation

antonio-rojas
Copy link
Contributor

sage -python is no longer available in the meson build

`sage -python` is no longer available in the meson build
Copy link

github-actions bot commented Apr 21, 2025

Documentation preview for this PR (built with commit 5ec8047; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Co-authored-by: Tobias Diez <code@tobiasdiez.com>
@vbraun
Copy link
Member

vbraun commented Apr 28, 2025

I'm getting

sage -t --long --warn-long 30.0 --random-seed=123 src/sage/tests/startup.py
**********************************************************************
File "src/sage/tests/startup.py", line 11, in sage.tests.startup
Failed example:
    print(test_executable(["python"], cmd)[0])  # long time
Expected:
    False
Got:
    <BLANKLINE>
**********************************************************************

is this using the system python?

@antonio-rojas
Copy link
Contributor Author

OK, so it seems this needs to be python3 after all, sage-the-distro's python doesn't install the python→python3 symlink.

It looks like none of the CI runners are using sage-the-distro's python, so this is no longer being CI tested?

vbraun pushed a commit to vbraun/sage that referenced this pull request May 1, 2025
sagemathgh-39997: Run python3 directly instead of `sage -python` in sage/tests/startup.py
    
`sage -python` is no longer available in the meson build
    
URL: sagemath#39997
Reported by: Antonio Rojas
Reviewer(s): Antonio Rojas, Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2025
sagemathgh-39997: Run python3 directly instead of `sage -python` in sage/tests/startup.py
    
`sage -python` is no longer available in the meson build
    
URL: sagemath#39997
Reported by: Antonio Rojas
Reviewer(s): Antonio Rojas, Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
sagemathgh-39997: Run python3 directly instead of `sage -python` in sage/tests/startup.py
    
`sage -python` is no longer available in the meson build
    
URL: sagemath#39997
Reported by: Antonio Rojas
Reviewer(s): Antonio Rojas, Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
sagemathgh-39997: Run python3 directly instead of `sage -python` in sage/tests/startup.py
    
`sage -python` is no longer available in the meson build
    
URL: sagemath#39997
Reported by: Antonio Rojas
Reviewer(s): Antonio Rojas, Tobias Diez
@vbraun vbraun merged commit d8d4156 into sagemath:develop May 11, 2025
22 of 23 checks passed
@antonio-rojas antonio-rojas deleted the sage-python branch May 11, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants