Skip to content

fix e_antic patch header #39976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix e_antic patch header #39976

merged 1 commit into from
Apr 29, 2025

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 19, 2025

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@isuruf isuruf requested review from saraedum and dimpase April 19, 2025 15:13
@isuruf
Copy link
Member Author

isuruf commented Apr 19, 2025

cc @jeriedel24

@dimpase
Copy link
Member

dimpase commented Apr 19, 2025

Does it apply manually?

@jeriedel24
Copy link

The original patch can be applied manually when using patch -p0.
The modified patch (with path prefixes a/ and b/) can be applied when using patch -p1. The build system does use patch -p1.

Copy link

Documentation preview for this PR (built with commit 0d0cf6c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 21, 2025
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#39976
Reported by: Isuru Fernando
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit 4c7c421 into sagemath:develop Apr 29, 2025
22 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants