Add offset argument to diagonal method #39963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 6b46019; changes) is ready! 🎉 |
user202729
reviewed
Apr 19, 2025
user202729
reviewed
Apr 19, 2025
|
The reviewed changes are resolved |
dcoudert
reviewed
Apr 20, 2025
dcoudert
suggested changes
Apr 21, 2025
|
@dcoudert Hi I've followed on the reviewed changes accordingly. Please let me know if anything else need to be changed |
dcoudert
suggested changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13564
This solves the mentioned issue, adding an offset argument that enables the user to get any diagonal parallel to the main diagonal. As mentioned in the documentation, off = 0 is default main diag, off > 0 is for above main, off < 0 for below.
📝 Checklist
⌛ Dependencies
cc @tscrim