Matrix singular values #39831
Merged
Matrix singular values #39831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfdf734 to
5808c56
Compare
5808c56 to
5c69ad7
Compare
1 task
|
Documentation preview for this PR (built with commit eed345f; changes) is ready! 🎉 |
|
One can also think of a better method for sparse matrices, as explicitly multiplying out m*m.H produces a fill-in, generally speaking. Surely there is stuff in ARPACK and maybe in SuiteSparse to handle this better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
.singular_values()for matrix. Previously it was only available forRBFandCBF.Should probably later add
algorithm=sympyusing #32171 , but is not in scope here.📝 Checklist
⌛ Dependencies
#39804 : while not strictly necessary, this makes the method more useful --- otherwise it raises a warning in base fields such as RR or CC