Improve NotImplementedError for sqrt(Mod(a,n), all=True) #39856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sqrt(Mod(a,n), all=True) is called for a non-square 'a' with the default extend=True, the resulting NotImplementedError was very generic. Improved the error message to suggest trying extend=False to find roots only within the base ring Zmod(n), as discussed in the issue. Included a doctest .
616133e to
ed69335
Compare
|
@maxale hello, can you review this and give feedback for the change made, |
It looks fine to me, but I'm not a reviewer here. |
|
@user202729 can you please review this and give feedback, |
|
Documentation preview for this PR (built with commit ee58fd4; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 21, 2025
sagemathgh-39856: Improve NotImplementedError for sqrt(Mod(a,n), all=True) Fixes sagemath#38802 When `sqrt(Mod(a,n), all=True)` is called for a non-square `a` with the default extend=True, the resulting `NotImplementedError` was very generic. Improved the error message to suggest trying extend=False to find roots only within the base ring Zmod(n), as discussed in the issue. Included doctest . <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39856 Reported by: Ashutosh Rajora Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38802
When
sqrt(Mod(a,n), all=True)is called for a non-squareawith the default extend=True, the resultingNotImplementedErrorwas very generic.Improved the error message to suggest trying extend=False to find roots only within the base ring Zmod(n), as discussed in the issue.
Included doctest .
📝 Checklist
⌛ Dependencies