Skip to content

add helper method _scream_if_immutable to graphs #39755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 25, 2025
Merged

add helper method _scream_if_immutable to graphs #39755

merged 11 commits into from
Jun 25, 2025
+80 −27

Conversation

dcoudert
Copy link
Contributor

As proposed in #39280 (comment), we add a helper method _scream_if_immutable to (di)graphs. We then use it in several methods trying to modify the graph.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Mar 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2025 •
edited
Loading

Documentation preview for this PR (built with commit b9b8366; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert dcoudert requested a review from fchapoton March 22, 2025 20:01
@fchapoton
Copy link
Contributor

La reparation de celui la doit marcher pareil, en reculant de deux pas, je pense.

@dcoudert dcoudert force-pushed the graphs/scream_if_immutable branch from 5a72b6d to f80590e Compare April 4, 2025 09:55
@dcoudert
Copy link
Contributor Author

dcoudert commented Apr 4, 2025

j'ai tout refait. Pas réussi le rebase ou autre.

@dcoudert dcoudert mentioned this pull request Apr 20, 2025
Merged
5 tasks
@dcoudert
Copy link
Contributor Author

dcoudert commented May 7, 2025

@fchapoton, could you help reviewing this PR ? Thanks.

@fchapoton
Copy link
Contributor

je sais bien que c'est moi qui ai proposé ca, mis je suis de moins en moins convaincu que c'est utile

@dcoudert
Copy link
Contributor Author

Je trouve ça très pratique. Ca évite de recopier systématiquement le même test / message d'erreur et permet d'unifier le type d'erreur.

@dcoudert dcoudert mentioned this pull request May 16, 2025
Merged
2 tasks
@fchapoton
Copy link
Contributor

Ca m'irait mieux avec un message un peu plus court ?

TypeError: This graph is immutable, so cannot be changed.
             Create a mutable copy using `g.copy(immutable=False)`

@dcoudert
Copy link
Contributor Author

Something like TypeError: this graph is immutable and so cannot be modified ?

@fchapoton
Copy link
Contributor

oui, ta proposition me convient. Je suis partisan de la sobriété, mais peut être un peu trop. :)

@dcoudert
Copy link
Contributor Author

Essayons comme ça. Il sera toujours possible de modifier le message après.

fchapoton
fchapoton approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dcoudert
Copy link
Contributor Author

Thank you.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 15, 2025
0bda9eb 
sagemathgh-39755: add helper method `_scream_if_immutable` to graphs
    
As proposed in
sagemath#39280 (comment), we
add a helper method `_scream_if_immutable` to (di)graphs. We then use it
in several methods trying to modify the graph.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39755
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 17, 2025
8f87cdd 
sagemathgh-39755: add helper method `_scream_if_immutable` to graphs
    
As proposed in
sagemath#39280 (comment), we
add a helper method `_scream_if_immutable` to (di)graphs. We then use it
in several methods trying to modify the graph.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39755
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 18, 2025
f4e3bbb 
sagemathgh-39755: add helper method `_scream_if_immutable` to graphs
    
As proposed in
sagemath#39280 (comment), we
add a helper method `_scream_if_immutable` to (di)graphs. We then use it
in several methods trying to modify the graph.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39755
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 21, 2025
779a8e6 
sagemathgh-39755: add helper method `_scream_if_immutable` to graphs
    
As proposed in
sagemath#39280 (comment), we
add a helper method `_scream_if_immutable` to (di)graphs. We then use it
in several methods trying to modify the graph.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39755
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit 581223c into sagemath:develop Jun 25, 2025
28 of 32 checks passed
@darijgr darijgr mentioned this pull request Jul 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees

@dcoudert dcoudert

Labels
c: graph theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcoudert @fchapoton @vbraun