-
-
Notifications
You must be signed in to change notification settings - Fork 648
Changed gens to tuple in AbstractLinearCodeNoMetric, mwrank_EllipticCurve, and FiniteSubgroup. #39660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…urve, and FiniteSubgroup.
Documentation preview for this PR (built with commit b90f0bb; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @DaveWitteMorris - OK? Please turn in to Positive Review
@dimpase: Should Also, two minor edits: line 379 of src/sage/coding/linear_code_no_metric.py
- Return the generators of this code as a list of vectors.
+ Return the generators of this code as a tuple of vectors.
line 574 of src/sage/libs/eclib/interface.py
- Return a list of the generators for the Mordell-Weil group.
+ Return a tuple of the generators for the Mordell-Weil group. |
@DaveWitteMorris Looking at the |
@DaveWitteMorris I've change the documentation of |
@DaveWitteMorris If you could take a look at this PR again and see if it is ready to be set to positive review that would be great! I think we we're discussing if a tuple is equivalent to an immutable sequence. |
I ran |
Pull request for part of the issue described in #34120. Changes the
gens
inAbstractLinearCodeNoMetric
,mwrank_EllipticCurve
, andFiniteSubgroup
to produce tuples.Possible Issues: In
mwrank_EllipticCurve
should thegens
be a tuple of lists or a tuple of tuples? The generators are points so I'm leaning towards tuple of list but I wanted to make sure. Then forFiniteSubgroup
is there anydifference between an immutable sequence and a tuple?
📝 Checklist
⌛ Dependencies