Overwrote methods concerning subdivision of edges in a matching covered graph #39650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit ac769cf; changes) is ready! 🎉 |
dcoudert
suggested changes
Mar 9, 2025
dcoudert
suggested changes
Mar 15, 2025
|
Hi, |
dcoudert
reviewed
Mar 23, 2025
dcoudert
reviewed
Mar 24, 2025
|
Hi @dcoudert, Could you please set it back to |
|
It was already back to needs review when you rebased on rc1. |
85dcb5c to
22eddb2
Compare
|
Your branch contains a commit that has been (unexpectedly) removed when going from 10.6.rc1 to 10.6. Can you restart your branch from a fresh develop branch of 10.7.beta0. |
7 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 18, 2025
sagemathgh-40090: Overwrote methods concerning subdivision of edge(s) in a matching covered graph <!-- ^ Please provide a concise and informative title. --> The objective of this issue is to overwrite the methods pertaining to subdivision of edges in a matching covered graph. <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> More specifically, this PR aims to overwrite the following methods: - [x] `subdivide_edge()` | Subdivide an edge `k` times. - [x] `subdivide_edges()` | Subdivide `k` times edges from an iterable container. <!-- v Why is this change required? What problem does it solve? --> This PR shall address the methods related to subdivision of edge(s) in matching covered graphs. <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38216. Note that this issue fixes a small part of the mentioned issue. This issue is the fresh restart of the issue sagemath#39650. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Nothing as of now. <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc: @dcoudert. URL: sagemath#40090 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 20, 2025
sagemathgh-40090: Overwrote methods concerning subdivision of edge(s) in a matching covered graph <!-- ^ Please provide a concise and informative title. --> The objective of this issue is to overwrite the methods pertaining to subdivision of edges in a matching covered graph. <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> More specifically, this PR aims to overwrite the following methods: - [x] `subdivide_edge()` | Subdivide an edge `k` times. - [x] `subdivide_edges()` | Subdivide `k` times edges from an iterable container. <!-- v Why is this change required? What problem does it solve? --> This PR shall address the methods related to subdivision of edge(s) in matching covered graphs. <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38216. Note that this issue fixes a small part of the mentioned issue. This issue is the fresh restart of the issue sagemath#39650. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Nothing as of now. <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc: @dcoudert. URL: sagemath#40090 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this issue is to overwrite the methods pertaining to subdivision of edges in a matching covered graph.
More specifically, this PR aims to overwrite the following methods:
subdivide_edge()| Subdivide an edgektimes.subdivide_edges()| Subdividektimes edges from an iterable container.This PR shall address the methods related to subdivision of edge(s) in matching covered graphs.
Fixes #38216.
Note that this issue fixes a small part of the mentioned issue.
📝 Checklist
⌛ Dependencies
Nothing as of now.
cc: @dcoudert.