Skip to content

Remove .ci directory #39642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 25, 2025
Merged

Remove .ci directory #39642

merged 9 commits into from
Jun 25, 2025

Conversation

tobiasdiez
Copy link
Contributor

Removes the .ci folder. It contains mostly outdated scripts that were used for gitlab CI.

  • A few scripts are needed for building the docker image, they are moved to docker
  • A few other scripts are used in the current github ci, they are moved to .github/workflows

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tobiasdiez tobiasdiez requested a review from user202729 March 7, 2025 11:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 76add5c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez tobiasdiez mentioned this pull request Mar 7, 2025
Merged
5 tasks
@user202729
Copy link
Contributor

user202729 commented Mar 7, 2025 •
edited
Loading

Looks good to me. Though the permission change on sage-version.sh looks accidental.

Also not sure where docker-exec-script should belong (if it isn't used to build docker I assume putting there is fine? Might be worth creating a docker/README.md then)

@saraedum Are the removed scripts useless now?

@tobiasdiez
Copy link
Contributor Author

Also not sure where docker-exec-script should belong (if it isn't used to build docker I assume putting there is fine? Might be worth creating a docker/README.md then)

It's only used in the github ci that is based on docker. Not for building the docker image that we provide. Thus it is similar to write-dockerfile.

user202729
user202729 reviewed Mar 14, 2025
View reviewed changes
.github/workflows/pyright.yml Outdated
@@ -24,23 +24,7 @@ jobs:

- name: Merge CI fixes from sagemath/sage
run: |
git config --global --add safe.directory "$GITHUB_WORKSPACE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this (not) do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are coming from a different PR, right? In either case, none of the other "Merge CI fixes" steps are using it.

@tobiasdiez
Copy link
Contributor Author

@user202729 are you happy with these changes? Would be nice to get this in.

@user202729
Copy link
Contributor

given the current situation it seems best to me to delay touching the CI too much in case it breaks something else…

@user202729
Copy link
Contributor

it actually broke something else. I think you need to change write-dockerfile.sh.

@tobiasdiez
Copy link
Contributor Author

it actually broke something else. I think you need to change write-dockerfile.sh.

Thanks! Should be fixed now.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 15, 2025
2ea9119 
sagemathgh-39642: Remove `.ci` directory
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Removes the `.ci` folder. It contains mostly outdated scripts that were
used for gitlab CI.

- A few scripts are needed for building the docker image, they are moved
to `docker`
- A few other scripts are used in the current github ci, they are moved
to `.github/workflows`

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39642
Reported by: Tobias Diez
Reviewer(s): Tobias Diez, user202729
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 17, 2025
8c912c2 
sagemathgh-39642: Remove `.ci` directory
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Removes the `.ci` folder. It contains mostly outdated scripts that were
used for gitlab CI.

- A few scripts are needed for building the docker image, they are moved
to `docker`
- A few other scripts are used in the current github ci, they are moved
to `.github/workflows`

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39642
Reported by: Tobias Diez
Reviewer(s): Tobias Diez, user202729
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 18, 2025
9e44cde 
sagemathgh-39642: Remove `.ci` directory
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Removes the `.ci` folder. It contains mostly outdated scripts that were
used for gitlab CI.

- A few scripts are needed for building the docker image, they are moved
to `docker`
- A few other scripts are used in the current github ci, they are moved
to `.github/workflows`

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39642
Reported by: Tobias Diez
Reviewer(s): Tobias Diez, user202729
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 21, 2025
9dea137 
sagemathgh-39642: Remove `.ci` directory
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Removes the `.ci` folder. It contains mostly outdated scripts that were
used for gitlab CI.

- A few scripts are needed for building the docker image, they are moved
to `docker`
- A few other scripts are used in the current github ci, they are moved
to `.github/workflows`

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39642
Reported by: Tobias Diez
Reviewer(s): Tobias Diez, user202729
@vbraun vbraun merged commit 4c9c8d9 into sagemath:develop Jun 25, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@user202729 user202729 user202729 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasdiez @user202729 @vbraun