Skip to content

move finite field methods #39532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 18, 2025
Merged

move finite field methods #39532

merged 7 commits into from
May 18, 2025

Conversation

mantepse
Copy link
Contributor

  • move is_field from Ring to Rings
  • adapt doctest
  • assert that a coercion cannot be registered after a conversion has been discovered, disable check for zero ring in is_field
  • move Ring.zeta and Ring.zeta_order
  • adapt doctests
  • move is_perfect, zeta, zeta_order

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@vneiger vneiger added the sd128 tickets of Sage Days 128 Le Teich label Feb 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 15, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 2d80c18; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

fchapoton
fchapoton reviewed Feb 17, 2025
View reviewed changes
fchapoton
fchapoton approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks good. I have committed my own small suggestion. Good to go

@mantepse
Copy link
Contributor Author

I am currently sick, but it seems to me that we haven't found a good solution to the problem with cellularbasis.one yet.

@fchapoton fchapoton mentioned this pull request May 11, 2025
Closed
@mantepse
Copy link
Contributor Author

OK, so is there anything left to be done here?

@fchapoton
Copy link
Contributor

well, the continuous integration seems to be very broken right now. So maybe one needs to run the full tests ourselves..

@mantepse
Copy link
Contributor Author

I'm doing that now, on ubuntu.

@mantepse
Copy link
Contributor Author

On Ubuntu 24.04.2 LTS all tests pass, except for two expected FriCAS failures.

@mantepse
Copy link
Contributor Author

So, the only question is whether we are doing the right thing here, design-wise. I cannot judge this.

fchapoton
fchapoton approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moving in the right direction, so positive review.

@vbraun vbraun merged commit 6151075 into sagemath:develop May 18, 2025
10 of 19 checks passed
@mantepse mantepse deleted the move_finite_field_methods branch May 19, 2025 11:05
@tscrim tscrim mentioned this pull request May 27, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
sd128 tickets of Sage Days 128 Le Teich t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mantepse @fchapoton @vbraun @vneiger