fix latex code in one crystal file #39594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit b7c2a75; changes) is ready! 🎉 |
|
The lines in the unicode_art method are the main suspect for the wrong behaviour |
|
For the unicode art, the rows are just printed in reverse order it looks like since it displays to the left instead of to the right. So just reversing the rows when passed into the table fixes things (line 178): - table = [[None] * (self.cols - len(row)) + row for row in reversed(self)]
+ table = [[None] * (self.cols - len(row)) + list(reversed(row)) for row in reversed(self)]So we can just fix it here if that's okay with you. |
|
right, indeed, fixed. |
seblabbe
added a commit
to seblabbe/sage
that referenced
this pull request
Feb 28, 2025
because these are now fixed in sagemath#39594
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 9, 2025
sagemathgh-39594: fix latex code in one crystal file and also notices a bug in the unicode art, fixed here. The issue about latex was noticed in sagemath#38759 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#39594 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also notices a bug in the unicode art, fixed here.
The issue about latex was noticed in #38759
📝 Checklist